Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csv read/write should be culture invariant #197

Closed
stalhandske opened this issue Jan 30, 2020 · 0 comments
Closed

Csv read/write should be culture invariant #197

stalhandske opened this issue Jan 30, 2020 · 0 comments

Comments

@stalhandske
Copy link

Since YarnSpinner string tables are generated on the build machine and could potentially be read by any device executing the game, the CsvHelper should use culture invariant formatting of the csv it generates and reads.

To fix this for myself i simply changed line 100 in YarnImport.cs to

var csv = new CsvHelper.CsvWriter(textWriter,new CsvHelper.Configuration.Configuration(System.Globalization.CultureInfo.InvariantCulture));

And something similar in DialogueRunner.cs

Note: string tables should be regenerated after this change (right click >> reimport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant