Update localizations button #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desplesda
requested changes
Apr 12, 2020
| } | ||
| } | ||
|
|
||
| public struct CsvEntry |
There was a problem hiding this comment.
If this struct isn't used outside this file, can it be private?
|
|
||
| mergedEntries.Sort((a, b) => a.lineNumber.CompareTo(b.lineNumber)); | ||
|
|
||
| //foreach (CsvEntry e in mergedEntries) |
There was a problem hiding this comment.
Can you remove this commented-out debugging code?
| @@ -160,4 +173,229 @@ public class YarnImporterEditor : ScriptedImporterEditor { | |||
|
|
|||
| AssetDatabase.ImportAsset(assetPath); | |||
| } | |||
|
|
|||
| void UpdateLocalizations(string newBaseCsv) | |||
There was a problem hiding this comment.
The documentation is really comprehensive in the second half of MergeStringTables, but there's a bit less in the first half and in UpdateLocalizations. Can you expand on the comments a bit?
There was a problem hiding this comment.
Yep, new commit up with more comments and fixes
- comments - removed debug code - cleaned up the for-loop in UpdateLocalizations() - fixed a place where it didn't add the "(((NEW LINE)))" to new lines - made the struct private
desplesda
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "Update Localizations" button to the Yarn Importer Editor. It goes through each string table CSVs in
localizations, compares it to the base string table, merges them based on a set of rules, and creates updated versions of the localizations in seperate files.Specifics on the merge rules used can be found as comments in the code.