Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-UPDATE] installCert = _args || yaml, instead of installCert = _args && yaml #101

Merged

Conversation

theshivamlko
Copy link
Contributor

Problem:
On remote computer like Codemagic CI/CD for Windows, terminal ask user input to proceed,
Do you want to install the certificate: "navoki_notes.pfx" ? (y/N)

and install-certificate is not passed in command line. SignTool command is also added signtool_options but still ask user input in terminal

signtool_options: "/v /t http://timestamp.digicert.com /fd sha256 /f navoki_notes.pfx /p 123456789 build\\windows\\runner\\Release\\NavokiNotes.exe"

Same configuration works on local PC.

Solution
Either variable is accepted to use or skip install-certificate to make build and release on auto-pilot mode

Change
installCert = _args['install-certificate'] != 'false' && yaml['install_certificate'] != 'false';
TO
installCert = _args['install-certificate'] != 'false' || yaml['install_certificate'] != 'false';

@theshivamlko theshivamlko changed the title [UPDATE] installCert = _args || yaml, instead of installCert = _args && yaml [FEATURE-UPDATE] installCert = _args || yaml, instead of installCert = _args && yaml Feb 15, 2022
@YehudaKremer YehudaKremer merged commit b6ba8d8 into YehudaKremer:main Feb 15, 2022
@YehudaKremer
Copy link
Owner

Thank you @theshivamlko

I published new version (3.1.0) with fix (did same fix configurations flags/options)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants