Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct flutter executable #201

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: use correct flutter executable #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions lib/src/windows_build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:io';
import 'package:cli_util/cli_logging.dart';
import 'package:get_it/get_it.dart';
import 'package:path/path.dart' as p;
import 'method_extensions.dart';
import 'configuration.dart';

Expand All @@ -11,19 +12,27 @@ class WindowsBuild {

/// Run "flutter build windows" command
Future<void> build() async {
List<String> buildWindowsArguments = ['build', 'windows'];
final flutterArgs = [
'build',
'windows',
...?_config.windowsBuildArgs,
if (_config.createWithDebugBuildFiles) '--debug',
];

if (_config.windowsBuildArgs != null) {
buildWindowsArguments.addAll(_config.windowsBuildArgs!);
}
// e.g. C:\Users\MyUser\fvm\versions\3.7.12\bin\cache\dart-sdk\bin\dart.exe
final dartPath = p.split(Platform.executable);

if (_config.createWithDebugBuildFiles) buildWindowsArguments.add('--debug');
// e.g. C:\Users\MyUser\fvm\versions\3.7.12\bin\flutter
final flutterPath = p.joinAll([
...dartPath.sublist(0, dartPath.length - 4),
'flutter',
]);

Progress loggerProgress = _logger
.progress('running "flutter ${buildWindowsArguments.join(' ')}"');
final Progress loggerProgress = _logger
.progress('running ""$flutterPath" ${flutterArgs.join(' ')}"');

// ignore: avoid_single_cascade_in_expression_statements
await Process.run('flutter', buildWindowsArguments, runInShell: true)
await Process.run(flutterPath, flutterArgs, runInShell: true)
..exitOnError();

loggerProgress.finish(showTiming: true);
Expand Down