Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Problem with installation #20

Closed
mannol opened this issue Jul 25, 2017 · 6 comments
Closed

Problem with installation #20

mannol opened this issue Jul 25, 2017 · 6 comments

Comments

@mannol
Copy link

mannol commented Jul 25, 2017

Running make install after compiling places headers in /usr/local/evhtp/ dir (under ubuntu). Using those global headers causes compilation to fail because evhtp.h includes files assuming they are installed in /usr/local/ dir instead.

@NathanFrench
Copy link
Collaborator

Wow, thanks, that's stupid. Let me fix.

@mannol
Copy link
Author

mannol commented Jul 25, 2017

Oh how lovely. Thank you!

NathanFrench added a commit that referenced this issue Jul 25, 2017
As stated within #20,
headers were being installed to include/evhtp/* but were not reflected
in the source.

This means that even though evhtp specific include files were in
/usr/include/evhtp/blah.h, a user still had to use -I/usr/include/evhtp
which is just dumb.

This is a holdover until we do a proper code refactor that splits up
various things logically.

So for now, ./include/evhtp == public
            ./include/. == private

Aside from the include/evhtp.h which is a placeholder that points
to include/evhtp/evhtp.h
@NathanFrench
Copy link
Collaborator

I think this is a short-term fix. What do you think?

@mannol
Copy link
Author

mannol commented Jul 25, 2017

It's okay as a short-term fix. It will be much better after general refactor, I'm sure.

@NathanFrench
Copy link
Collaborator

Yep.

@NathanFrench
Copy link
Collaborator

merged and closing. Thanks for pointing this out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants