optimizer param struct improvements #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ GradientDescentParameters now tracks num_steps_averaged (but doesnt use it)
|
|
||
| @classmethod | ||
| @pytest.fixture(autouse=True, scope='class') | ||
| def base_setup(cls): |
There was a problem hiding this comment.
cls, see @classmethod decorator. this is so that these objects are created once per test class, equivalent of class_setup in testify
|
Looks good, some quick questions in the tests, I'm happy to 🐑 though. |
suntzu86
added a commit
that referenced
this pull request
Dec 1, 2014
…members_to_python optimizer param struct improvements
suntzu86
deleted the
eliu_gh_138_expose_cpp_struct_data_members_to_python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
********* PEOPLE *************
Primary reviewer: @sc932
Reviewers:
********* DESCRIPTION **************
Branch Name: eliu_gh_138_expose_cpp_struct_data_members_to_python
Ticket(s)/Issue(s): Closes #138 Closes #391
meat of change in:
moe/optimal_learning/cpp/gpp_optimizer_parameters.hpp
moe/optimal_learning/cpp/gpp_python_common.cpp
moe/optimal_learning/python/comparison.py
moe/optimal_learning/python/cpp_wrappers/optimization.py
moe/tests/optimal_learning/python/comparison_test.py
moe/tests/optimal_learning/python/cpp_wrappers/optimization_test.py
C++ optimizer param structs now direclty readable/writeable from Python
C++ GradientDescentParameters now tracks num_steps_averaged (but doesnt use it)
********* TESTING DONE *************
make test
manual checking