Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #471

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor fixes #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4c54f4
Fix compile: add missing <numeric> include
dstoeckel Oct 10, 2017
0cc6b98
Fix warnings in gpp_optimization.hpp
dstoeckel Oct 10, 2017
49f5fa9
Fix warnings in gpp_test_utils.cpp
dstoeckel Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moe/optimal_learning/cpp/gpp_optimization.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ class MultistartOptimizer final {
// allocated objects, bad state, etc).

// Guarantee: only one exception will ever be captured; only one thread will ever execute the lambda function.
std::call_once(exception_capture_flag, [&captured_exception]() {
std::call_once(exception_capture_flag, [&captured_exception]() noexcept {
captured_exception = std::current_exception();
});
}
Expand Down
1 change: 1 addition & 0 deletions moe/optimal_learning/cpp/gpp_optimization_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#include <cmath>

#include <algorithm>
#include <numeric>
#include <string>
#include <vector>

Expand Down
2 changes: 1 addition & 1 deletion moe/optimal_learning/cpp/gpp_test_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ bool CheckIntEquals(int64_t value, int64_t truth) noexcept {
bool passed = value == truth;

if (passed == false) {
OL_ERROR_PRINTF("value = %lld, truth = %lld, diff = %lld\n", value, truth, truth-value);
OL_ERROR_PRINTF("value = %ld, truth = %ld, diff = %ld\n", value, truth, truth-value);
}
return passed;
}
Expand Down