Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Drop Python 2 support #292

Merged
merged 10 commits into from
Mar 31, 2020
Merged

💥 Drop Python 2 support #292

merged 10 commits into from
Mar 31, 2020

Conversation

KevinHock
Copy link
Collaborator

💥

There may be some leftovers regarding Bytes/Unicode like from #223 and there is

detect-secrets/testing/mocks.py

Lines 24 to 27 in 9d8fe79

# We need to use a dictionary, because python2.7 does not support
# the `nonlocal` keyword (and needs to share scope with
# _mock_single_git_call function)
current_case = {'index': 0}

But, those seem like good-first-issues or things we can clean up later. Didn't want to spend much time on this tbh.

@domanchi domanchi mentioned this pull request Mar 31, 2020
Closed
domanchi
domanchi approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@domanchi domanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure that this goes in a breaking change version bump.

@KevinHock KevinHock merged commit d94b92f into master Mar 31, 2020
@KevinHock KevinHock deleted the python3 branch March 31, 2020 17:53
@KevinHock KevinHock mentioned this pull request Apr 4, 2020
Merged
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request May 28, 2020
Catch api_key for SL token (Yelp#292)
ecca6c2
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Jul 9, 2020
@justineyster
Catch api_key for SL token (Yelp#292)
985232f
killuazhu pushed a commit to IBM/detect-secrets that referenced this pull request Sep 17, 2020
@justineyster
Catch api_key for SL token (Yelp#292)
c05daa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domanchi domanchi domanchi approved these changes

@OiCMudkips OiCMudkips Awaiting requested review from OiCMudkips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinHock @asottile @domanchi