-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Discord Bot token detector #614
Conversation
Hi @lorenzodb1, I don't know why is failing the CI detect-secrets unit tests. It seems a problem in the source code checkout step. Could you check it and rerun the jobs (it seems a punctual error in 1 runner)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 . Thanks for your contribution. Can we add some failure test cases as well?
Yes, sounds good! I upload 3 new tests cases, but it is failing again... Could you rerun it? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did anything change here?
@jpdakran reverted 😄 |
Thank you for your contribution @syn-4ck! Your PR was merged and will be included in the 1.4.0 release 😄 |
Thanks! I'm going to continue helping you improving the tool. Good job team! |
Closes #613