Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discord Bot token detector #614

Merged
merged 7 commits into from
Sep 26, 2022

Conversation

syn-4ck
Copy link
Contributor

@syn-4ck syn-4ck commented Sep 20, 2022

Closes #613

@syn-4ck
Copy link
Contributor Author

syn-4ck commented Sep 20, 2022

Hi @lorenzodb1, I don't know why is failing the CI detect-secrets unit tests. It seems a problem in the source code checkout step. Could you check it and rerun the jobs (it seems a punctual error in 1 runner)?

Copy link
Member

@jpdakran jpdakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Thanks for your contribution. Can we add some failure test cases as well?

@syn-4ck
Copy link
Contributor Author

syn-4ck commented Sep 20, 2022

Looks good 👍 . Thanks for your contribution. Can we add some failure test cases as well?

Yes, sounds good! I upload 3 new tests cases, but it is failing again... Could you rerun it? Thanks.

Copy link
Member

@jpdakran jpdakran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anything change here?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@syn-4ck
Copy link
Contributor Author

syn-4ck commented Sep 20, 2022

@jpdakran reverted 😄

@syn-4ck syn-4ck requested review from lorenzodb1 and jpdakran and removed request for jpdakran and lorenzodb1 September 20, 2022 18:52
@lorenzodb1 lorenzodb1 merged commit 0dcd54c into Yelp:master Sep 26, 2022
@lorenzodb1
Copy link
Contributor

Thank you for your contribution @syn-4ck! Your PR was merged and will be included in the 1.4.0 release 😄

@syn-4ck
Copy link
Contributor Author

syn-4ck commented Sep 26, 2022

Thank you for your contribution @syn-4ck! Your PR was merged and will be included in the 1.4.0 release 😄

Thanks! I'm going to continue helping you improving the tool. Good job team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Discord Bot Token plugin
3 participants