Audit prompt wording #738
Merged
Audit prompt wording #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old audit prompt message was confusing in the case of a false positive. This new wording suits both genuine findings and false positives. Fixes Yelp#734
lorenzodb1
reviewed
Nov 24, 2023
lorenzodb1
approved these changes
Apr 29, 2024
|
Thank you for your contribution @direvus! I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the wording of the audit prompt, so that it makes sense for false positives as well as genuine detections.
This was initially raised as issue #734
The current audit prompt is confusing for false positives.
The prompt now omits any reference to the detection being a secret (since we don't know whether it is or isn't at this point)
No