Set pipefail for test-zombies to not mask errors

Yelp · Jan 7, 2016 · 4b37e64 · 4b37e64
1 parent ffaa420
commit 4b37e64
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -1,6 +1,6 @@
 CFLAGS=-std=gnu99 -static -Wall -Werror -O3
 
-TEST_PACKAGE_DEPS := python python-pip
+TEST_PACKAGE_DEPS := python python-pip procps
 
 DOCKER_RUN_TEST := docker run -v $(PWD):/mnt:ro
 

diff --git a/tests/test-zombies b/tests/test-zombies
@@ -6,11 +6,12 @@
 # We run it as the last step of the integration tests inside our Docker
 # containers. Since dumb-init must run as PID 1, we don't use pytest and
 # instead write it in bash (which gets executed by PID1 dumb-init).
+set -o pipefail
 
 bash -euxc "bash -euxc 'echo i am a zombie' &" &
 
 sleep 1
-num_zombies=$(ps -A -o state | grep 'Z' | wc -l)
+num_zombies=$(ps -A -o state | (grep 'Z' || true) | wc -l)
 
 if [ "$num_zombies" -ne 0 ]; then
     echo "Expected no zombies, but instead there were ${num_zombies}."