Fix SNS(Program & Docs) #2793
Closed
Fix SNS(Program & Docs) #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…nto fix-aws_profile-sns
…nto fix-aws_profile-sns
This was referenced Nov 17, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review setting name
I was planning to review only aws_region, but I thought that the same name may be used for other names, so I added "sns_" to the beginning.
I also modified the documentation
・aws_access_key_id
→ sns_aws_access_key_id
・aws_secret_access_key
→ sns_aws_secret_access_key
・aws_region
→ sns_aws_region
・aws_profile
→ sns_aws_profile
Profile bug fix
It was fixed because the implementation when using the profile was in an incorrect state.