Fix Incorrect Opsgenie Tags Formatting #2884
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple matches in a single run of ElastAlert and the Opsgenie Tags are dynamic (deriving value from matching documents) then when the tag field for each unique alert is formatted only from the values of the first match. e.g.
Input:
opsgenie_tags: ["user"]
matches: ["alice", "bob"]
Expected Alerts:
Alert1: opsgenie_tags: ["alice"]
Alert2: opsgenie_tags: ["bob"]
Actual Alerts:
Alert1: opsgenie_tags: ["alice"]
Alert2: opsgenie_tags: ["alice"]
Fix
Instead of formatting a tag and changing its value in the entire objects state(self.tags), make a new variable that stores the formatted value, and directly add it to the post object that will be sent by the Opsgenie Alerter.