Allow developers to whitelist tags for fuzzing #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2019 16:38
This makes it so that developers can whitelist tags into being included in the fuzzing process. This is useful for when certain parts of the spec are ready for fuzzing, but others aren't.
domanchi
approved these changes
Oct 16, 2019
fuzz_lightyear/generator.py
Outdated
| from .output.util import print_warning | ||
| from .request import FuzzingRequest | ||
| from .result import FuzzingResult | ||
| from .supplements.abstraction import get_abstraction | ||
|
|
||
|
|
||
| def get_fuzzable_tags(client: Optional[SwaggerClient]) -> List[str]: | ||
| """Given a Swagger client, returns a list of tags that should | ||
| actually be fuzzed. This respects the user-defined whitelist for |
There was a problem hiding this comment.
Super duper nit: whitelist -> allowlist for consistency sake?
margaretgorguissian
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
This is useful for when certain parts of the Swagger spec are ready for fuzzing, but others aren't.
Explanation of code
The approach is basically identical to #9, except this handles Swagger tags instead of operations (and is therefore much simpler).
Question
I feel like
includelistanddenylistare better name thaninclusionsandexclusions. What do you two think? Should I change it? This would make the decorators look like:instead of
Bonus
Add a travis badge to the README cause it looks "good" for some definition of good (pics: https://github.com/Yelp/fuzz-lightyear/blob/fuzz_only_input_tags/README.md)