Cherry-pick fix to fetch consumer metadata #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cluster metadata object has no info about the topic, then issue a blocking metadata call to fetch it.
|
+1 |
|
Nice work on this! Thanks for including the new test in addition to your cherry-picking from upstream. |
|
@lsterk the new test was also cherry-picked from upstream :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.4.5 introduced a regression where some fetches of consumer metadata were nonblocking (i.e. used local state instead of making a network call) unless a network operation was performed at some point. Unfortunately there was a bug where if the metadata was empty, the code just assumed there was no data at all and did not make a blocking call to fetch any data.
I made a fix upstream (see dpkp#1781) but it hasn't been released yet (probably in 1.4.7). So we can just cherry-pick the change in our fork now.