This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Adding Jolokia authentication support #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EladLeev , this seems reasonable and thank you for contributing! Would you mind squashing your commits first? |
Adding the ability to authenticate to Jolokia using username and password by providing `--jolokia-user` and `--jolokia-password` Update `kafka_rolling_restart` doc Adding the user and password flags to `kafka_rolling_restart` doc Change 401 error msg Change the 401 error msg to "Jolokia Authentication Failed. Exiting." Updated tests `wait_for_stable_cluster` and `read_cluster_status` now takes 5 arguments. IRL - They will get `None` from `argparse` default value. Update main.py missing white space
|
@Baisang Sure. |
Baisang
approved these changes
Feb 4, 2020
|
Sorry, I totally forgot about this. Merging now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
We use user & password in order to authenticate to Jolokia in our organization.
I added the ability to provide it by passing 2 more arguments -
--jolokia-passwordand--jolokia-user.In case of bad authentication credentials (401), the user will face
Jolokia Authentication Failed. Exiting.error.I updated the
docs/source/kafka_rolling_restart.rstdoc as well.Thanks 🙃