Skip to content

Commit

Permalink
Add quotes around new label name in label_replace (#3700)
Browse files Browse the repository at this point in the history
* [COREJAVA-888] Add kube deployment label to envoy metrics aggregation

* Format

* Add missing quotes

* PR Feedback - update regex in label_replace and add comment

* Add quotes around new label name in label_replace
  • Loading branch information
sclg-yelp authored Sep 11, 2023
1 parent 94f64f3 commit 2ab6df1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion paasta_tools/setup_prometheus_adapter_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def create_instance_active_requests_scaling_rule(
avg(
paasta_instance:envoy_cluster__egress_cluster_upstream_rq_active{{{worker_filter_terms}}}
),
"kube_deployment", {deployment_name}, "", ""
"kube_deployment", "{deployment_name}", "", ""
)
"""
missing_instances = f"""
Expand Down

0 comments on commit 2ab6df1

Please sign in to comment.