Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the service configuration library to set up Spark on Tron #2601

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Dec 19, 2019

This uses the changes in Yelp/service_configuration_lib#39 to set up a spark environment for Tron. Tested manually, but there's still going to be more work to do.

I also made changes so that we actually get a "real" development virtualenv for paasta, cuz I'm sick of typing .tox/py36-linux/bin/pytbnon all the time.

@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch 2 times, most recently from 1e07480 to aea3fdb Compare December 20, 2019 23:51
@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch 2 times, most recently from 8c4a7fc to 34e46cd Compare December 26, 2019 18:05
@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch from e10e18c to 8552e6a Compare December 27, 2019 17:07
@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch 3 times, most recently from 117ea21 to 4130da2 Compare December 27, 2019 19:39
@drmorr0
Copy link
Contributor Author

drmorr0 commented Dec 27, 2019

I had to mess around with a bunch of travis nonsense to get the build to pass. It seems like we're running into (some variant of) pypa/pip#6275. I used the python setup.py egg_info workaround which appears to fix things.

@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch from 4130da2 to a48a99c Compare December 27, 2019 20:07
Copy link
Contributor

@stug stug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. Are we planning to do another pass and make spark-tools to use the code in service_configuration_lib, too?

@drmorr0
Copy link
Contributor Author

drmorr0 commented Jan 2, 2020

Mostly looks good to me. Are we planning to do another pass and make spark-tools to use the code in service_configuration_lib, too?

@stug Yes, but we need to get all of the existing Tron jobs that use paasta spark-run using this first.

@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch from a48a99c to 2f4fadd Compare January 2, 2020 20:42
@drmorr0 drmorr0 force-pushed the drmorr/TRON-1369/spark_on_tron branch from 2f4fadd to 8d76e3b Compare January 2, 2020 20:42
@drmorr0 drmorr0 merged commit 60b977e into master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants