-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the service configuration library to set up Spark on Tron #2601
Conversation
1e07480
to
aea3fdb
Compare
8c4a7fc
to
34e46cd
Compare
e10e18c
to
8552e6a
Compare
117ea21
to
4130da2
Compare
I had to mess around with a bunch of travis nonsense to get the build to pass. It seems like we're running into (some variant of) pypa/pip#6275. I used the |
4130da2
to
a48a99c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Are we planning to do another pass and make spark-tools to use the code in service_configuration_lib, too?
@stug Yes, but we need to get all of the existing Tron jobs that use |
a48a99c
to
2f4fadd
Compare
2f4fadd
to
8d76e3b
Compare
This uses the changes in Yelp/service_configuration_lib#39 to set up a spark environment for Tron. Tested manually, but there's still going to be more work to do.
I also made changes so that we actually get a "real" development virtualenv for paasta, cuz I'm sick of typing
.tox/py36-linux/bin/pytbnon
all the time.