Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around new label name in label_replace #3700

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Add quotes around new label name in label_replace #3700

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
234dd0b
[COREJAVA-888] Add kube deployment label to envoy metrics aggregation
sclg-yelp Sep 11, 2023
2ddb89c
Format
sclg-yelp Sep 11, 2023
a9db72e
Add missing quotes
sclg-yelp Sep 11, 2023
c7787bf
PR Feedback - update regex in label_replace and add comment
sclg-yelp Sep 11, 2023
1e4b46d
Add quotes around new label name in label_replace
sclg-yelp Sep 11, 2023
dec022b
Merge branch 'master' into sclg/COREJAVA-888/add_kube_deployment_label
sclg-yelp Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paasta_tools/setup_prometheus_adapter_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def create_instance_active_requests_scaling_rule(
avg(
paasta_instance:envoy_cluster__egress_cluster_upstream_rq_active{{{worker_filter_terms}}}
),
"kube_deployment", {deployment_name}, "", ""
"kube_deployment", "{deployment_name}", "", ""
)
"""
missing_instances = f"""
Expand Down