Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pod identity in spark-run #3828

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Conversation

nurdann
Copy link
Member

@nurdann nurdann commented Apr 12, 2024

Changes

@nurdann
Copy link
Member Author

nurdann commented Apr 23, 2024

Manually setting pod identity worked https://fluffy.yelpcorp.com/i/3Gcd1qTzDjNP1z4zKD3t7c4D1d7SHDd8.html

Note that I had to manually set duration to --aws-role-duration 3600 because that's role's max session duration, and the default is above that

@nurdann
Copy link
Member Author

nurdann commented Apr 23, 2024

Don't get why setting autospec=True fails for 98b1217 with

FAILED tests/cli/test_cmds_spark_run.py::test_get_aws_credentials - TypeError: autospec creates the mock for you. Can't specify autospec and new.

@88manpreet
Copy link
Contributor

Change lgtm. Can you update the documentation https://yelpwiki.yelpcorp.com/pages/viewpage.action?pageId=283750257, to append the section with following details:

  • In what cases user should use --use-web-identity argument
  • An example

If possible would suggest to push on Monday.

@nurdann nurdann merged commit c70d69c into master Apr 29, 2024
9 checks passed
@88manpreet
Copy link
Contributor

+1. Thanks for adding in documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants