Clean up code relating to decision_policy and forecast_policy. #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s gone. PAASTA-18298
…round decision_policy to be a little more accurate.
EvanKrall
changed the title
EvanKrall
requested review from
cuza,
jfongatyelp and
nemacysts
and removed request for
cuza and
jfongatyelp
|
I could be convinced to drop the |
nemacysts
previously approved these changes
Sep 13, 2024
There was a problem hiding this comment.
the decision policy changes seem pretty safe to me - imo, it's probably fine to leave them in
(and i agree that we should probably change how bespoke autoscaling works in the future - i think that even the current owners get confused by how this works now: we've had a non-zero amount of onpoint requests from these owners where they've thought something was broken since there were no HPAs :p)
| :bespoke: | ||
| Allows a service author to implement their own autoscaling. | ||
| This policy results in no HPA being configured. | ||
| An external process should periodically decide how many replicas this service needs to run, and use the Paasta API to tell Paasta to scale. | ||
| See the :ref:`How to create a custom (bespoke) autoscaling method` section for details. | ||
| This is most commonly used by the Kew autoscaler. | ||
|
|
||
| :Anything other value: |
There was a problem hiding this comment.
was this meant to be Any other value:?
…8298_delete_forecast_policy_decision_policy
nemacysts
reviewed
Dec 3, 2024
| :bespoke: | ||
| Allows a service author to implement their own autoscaling. | ||
| This policy results in no HPA being configured. | ||
| An external process should periodically decide how many replicas this service needs to run, and use the Paasta API to tell Paasta to scale. | ||
| See the :ref:`How to create a custom (bespoke) autoscaling method` section for details. | ||
| This is most commonly used by the Kew autoscaler. | ||
|
|
||
| :Anything other value: |
There was a problem hiding this comment.
Suggested change
| :Anything other value: | |
| :Any other value: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to ship a yelpsoa-configs change that stops setting
forecast_policybefore we ship this.