Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/V1beta1PodDisruptionBudget/V1PodDisruptionBudget/ for COMPINFRA-4409 #3990

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

EvanKrall
Copy link
Member

@EvanKrall EvanKrall commented Dec 4, 2024

This seems to work fine -- I've confirmed via the paasta playground that it's going through the V1PodDisruptionBudget code paths at least, and seems to function in the 1.24-based playground.

I tried upgrading the playground to 1.25 but then my pods are Pending forever -- I suspect it's just something with the playground. Without the changes in this PR, testing setup_kubernetes_job against the 1.25 playground results in

ERROR:__main__:Error while processing: compute-infra-test-service-autoscaling-cb9e0385bfc73cb2288a5b12894720ab3d2a744f-config2468529d
Traceback (most recent call last):
  File "/nail/home/krall/pg/paasta/paasta_tools/setup_kubernetes_job.py", line 324, in setup_kube_deployments
    app.update_related_api_objects(kube_client)
  File "/nail/home/krall/pg/paasta/paasta_tools/kubernetes/application/controller_wrappers.py", line 278, in update_related_api_objects
    super().update_related_api_objects(kube_client)
  File "/nail/home/krall/pg/paasta/paasta_tools/kubernetes/application/controller_wrappers.py", line 122, in update_related_api_objects
    self.ensure_pod_disruption_budget(kube_client, self.soa_config.get_namespace())
  File "/nail/home/krall/pg/paasta/paasta_tools/kubernetes/application/controller_wrappers.py", line 212, in ensure_pod_disruption_budget
    return create_pod_disruption_budget(
  File "/nail/home/krall/pg/paasta/paasta_tools/kubernetes_tools.py", line 3216, in create_pod_disruption_budget
    return kube_client.policy.create_namespaced_pod_disruption_budget(
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/api/policy_v1beta1_api.py", line 67, in create_namespaced_pod_disruption_budget
    return self.create_namespaced_pod_disruption_budget_with_http_info(namespace, body, **kwargs)  # noqa: E501
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/api/policy_v1beta1_api.py", line 166, in create_namespaced_pod_disruption_budget_with_http_info
    return self.api_client.call_api(
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/api_client.py", line 348, in call_api
    return self.__call_api(resource_path, method,
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/api_client.py", line 180, in __call_api
    response_data = self.request(
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/api_client.py", line 391, in request
    return self.rest_client.POST(url,
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/rest.py", line 275, in POST
    return self.request("POST", url,
  File "/nail/home/krall/pg/paasta/.tox/py38-linux/lib/python3.8/site-packages/kubernetes/client/rest.py", line 234, in request
    raise ApiException(http_resp=r)
kubernetes.client.exceptions.ApiException: (404)

so this at least makes progress.

@EvanKrall EvanKrall requested review from wilmer05 and cuza December 4, 2024 01:03
@EvanKrall EvanKrall requested a review from a team as a code owner December 4, 2024 01:03
@EvanKrall EvanKrall merged commit 19968c2 into master Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants