Skip to content
This repository was archived by the owner on Apr 18, 2018. It is now read-only.

fix some bug #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix some bug #67

wants to merge 1 commit into from

Conversation

jiangrzh
Copy link

@jiangrzh jiangrzh commented Jan 7, 2015

fix:

  1. connection socket opt set to struct.pack('I', 1) for some 64bit OS
  2. catch exception when current_request =
    self.handle_to_request_map[job_handle] throw KeyError

@jiangrzh
fix some bug
225b27a 
fix:
1) connection socket opt set to struct.pack('I', 1) for some 64bit OS
2) catch exception when current_request =
self.handle_to_request_map[job_handle] throw KeyError
@svisser
Copy link

svisser commented Apr 26, 2015

How can self.handle_to_request_map throw a KeyError for some job handles? It doesn't seem right to catch the KeyError and ignore them.

@svisser
Copy link

svisser commented Apr 26, 2015

Ah: https://github.com/paiweilai1984/python-gearman/commit/eba998b2706aacd4f11ce09b7c12175803dd3a9a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangrzh @svisser