Update SharedCodegen to fallback to title usage if x-model is not present #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current plugin does use
x-model
field for model name determination.According to the swagger specification
title
should be used to define the model name.Internally, in Yelp, we heavily use
x-model
custom vendor extension to be able to define names also for objects that do not allow the presence of title.The goal of this PR is to ensure that
title
is honoured if present and used as fallback in casex-model
is not present.Let's get the following specs
Before this PR the generated models would be:
def1
for#/definitions/def1
model2
for#/definitions/def2
def3
for#/definitions/def3
model4
for#/definitions/def4
After this PR the generated models would be:
def1
for#/definitions/def1
model2
for#/definitions/def2
title3
for#/definitions/def3
DIFFERENTmodel4
for#/definitions/def4