Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend visibility of Custom Moshi Adapters #30

Merged
merged 1 commit into from
May 31, 2019

Conversation

cortinico
Copy link
Collaborator

I'm extending the visibility of the custom Moshi Adapters TypesAdapterFactory and XNullableAdapterFactory from internal to public. This will support the use case of developers that want to initialise their own Moshi instance and want to provide custom Type adapters on top of the generated ones.

Fore more context see the doc here

    /**
     * Creates everything needed for retrofit to make it work with the client lib, including a
     * [Moshi] instance. If you want to use your own instance of moshi, use
     * converterFactory(moshi) instead, and add [XNullableAdapterFactory], [KotlinJsonAdapterFactory] and
     * [TypesAdapterFactory] to your moshi builder (in a similar way how we are instantiating the `moshi` field here).
     */

@cortinico cortinico self-assigned this May 31, 2019
@cortinico cortinico merged commit cf332b2 into master May 31, 2019
@cortinico cortinico deleted the extend-typeadapter-visibility branch June 4, 2019 13:17
@cortinico cortinico added this to the 1.1.0 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants