Annotate with @JsonClass classes with no parameters/variables #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because if we would fully remove
moshi-kotlin
dependency (as planned by version 2 release) we would not be able to properly have the Json to Object conversion and vice-versa.The most important change introduced by this PR is visible into
samples/junit-tests/.../models/EmptyModel.kt
.The reason for forcing the presence of
@JsonClass(generateAdapter = true)
even if there are no attributes is related to the fact that if we would remove the usage ofKotlinJsonAdapterFactory
then we would not be able to covert theEmptyModel
instance from/toJSON
.In order to validate it I've run this script.
The script basically ensures that we have no moshi-kotlin/kotlin-reflect dependencies on samples/junit-tests and runs the tests
The results (raw results in here), as expected, shows that:
emptyEndpointTest_withEmptyBody
test.The test failure contains the following exception (the raw exception is available here)