-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial stab at adding TSC support to task_proc #220
Conversation
This should help Karpenter spread things out.
@@ -88,3 +88,10 @@ class PodEvent(TypedDict): | |||
object: V1Pod | |||
# this is just the dict-ified version of object - but it's too big to type here | |||
raw_object: Dict[str, Any] | |||
|
|||
|
|||
class TopologySpreadContraint(TypedDict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to create a local class since it exists in k8s lib?
I am asking because TSC will be changed in next(ish) release.
e.g. nodeAffinityPolicy, nodeTaintsPolicy, matchLabelKeys, minDomains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for the typing task_proc task_config data: we get data as dicts and then later translate them to k8s objects
I tested this with a local tron using with something like
and pods were correctly spun up with
in their pod specs (and I saw pods launch across multiple AZs) |
Co-authored-by: Jen Patague <jfong@yelp.com>
This should help Karpenter spread things out.