Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat batch effects #253

Merged
merged 12 commits into from
May 8, 2015
Merged

Combat batch effects #253

merged 12 commits into from
May 8, 2015

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Feb 3, 2015

To work on this: #252

This is for the milestone 0.3.0

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new plot, is it documented in the gallery?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@olgabot olgabot added this to the 0.3.0 milestone Feb 3, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.38%) to 42.17% when pulling 6b32335 on combat_batch_effects into 02966de on master.

@olgabot olgabot force-pushed the combat_batch_effects branch from 6b32335 to 2653d69 Compare May 8, 2015 03:04
olgabot added a commit that referenced this pull request May 8, 2015
@olgabot olgabot merged commit 6851662 into master May 8, 2015
@olgabot olgabot deleted the combat_batch_effects branch May 8, 2015 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants