Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplemental data #272

Merged
merged 16 commits into from
Mar 17, 2015
Merged

Supplemental data #272

merged 16 commits into from
Mar 17, 2015

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Mar 13, 2015

Allow the user to save any arbitrary pandas dataframe as "supplemental" data on the study, e.g.

study.supplemental.tf_corr = tfs.corr()

Any data saved to the study.supplemental object will be saved as part of the datapackage and reloaded upon embark.

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new plot, is it documented in the gallery?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 51.04% when pulling ce91f11 on supplemental_data into 5dd63d3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.65%) to 51.39% when pulling 8c7705e on supplemental_data into 5dd63d3 on master.

olgabot added a commit that referenced this pull request Mar 17, 2015
@olgabot olgabot merged commit fc88ff0 into master Mar 17, 2015
@olgabot olgabot deleted the supplemental_data branch March 17, 2015 00:02
@olgabot olgabot restored the supplemental_data branch March 17, 2015 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants