Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting changes #285

Merged
merged 10 commits into from
Apr 8, 2015
Merged

Plotting changes #285

merged 10 commits into from
Apr 8, 2015

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Apr 8, 2015

  • Variable width violin plots for when you have lots of phenotypes
  • Change default phenotype to marker from circle to a variety of shapes because it can be hard to tell between label colors

before and after of variable width violin plots
before:
image

After:
image

Before and afters of changing default phenotype to marker:
Before:
image

After:
image

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new feature, is it documented as an IPython Notebook in
    examples/, and is that notebook added to doc/tutorial.rst?
  • If it adds a new plot, is it documented in the gallery, as a .py file
    in examples/?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@olgabot
Copy link
Collaborator Author

olgabot commented Apr 8, 2015

Note: this is on the brain span data and I also filtered out the brain structures with fewer than 10 samples in between the "befores" and "afters" because it's difficult to interpret

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 52.67% when pulling 42cbcb8 on variable_width_violin_plots into 2f9e6e9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 52.8% when pulling c827e26 on variable_width_violin_plots into 2f9e6e9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.25%) to 52.85% when pulling 25d5cab on variable_width_violin_plots into 2f9e6e9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.67%) to 53.27% when pulling 9030cca on variable_width_violin_plots into 2f9e6e9 on master.

olgabot added a commit that referenced this pull request Apr 8, 2015
@olgabot olgabot merged commit b178977 into master Apr 8, 2015
@olgabot olgabot deleted the variable_width_violin_plots branch May 8, 2015 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants