Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure boolean columns are used as sample/feature subsets #290

Merged
merged 3 commits into from
Apr 10, 2015

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Apr 8, 2015

addresses: #289

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new feature, is it documented as an IPython Notebook in
    examples/, and is that notebook added to doc/tutorial.rst?
  • If it adds a new plot, is it documented in the gallery, as a .py file
    in examples/?
  • Is it well formatted? Look at make pep8 and make lint output
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.16%) to 53.43% when pulling 13067fa on boolean_feature_subsets into b178977 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.46%) to 53.73% when pulling 6078455 on boolean_feature_subsets into b178977 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.46%) to 53.73% when pulling 6078455 on boolean_feature_subsets into b178977 on master.

olgabot added a commit that referenced this pull request Apr 10, 2015
make sure boolean columns are used as sample/feature subsets
@olgabot olgabot merged commit dfec06b into master Apr 10, 2015
@olgabot olgabot deleted the boolean_feature_subsets branch May 8, 2015 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants