Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, rasterize the lavalamp plot #308

Merged
merged 15 commits into from
May 28, 2015
Merged

By default, rasterize the lavalamp plot #308

merged 15 commits into from
May 28, 2015

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented May 22, 2015

Add the keyword argument raster=True for violinplots since they get so gigantic. kudos to @theandygross who pointed to http://www.astrobetter.com/blog/2014/01/17/slim-down-your-bloated-graphics/

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in is it tested?
    Check for code coverage. To run code coverage on only the file you changed,
    for example flotilla/compute/splicing.py, use this command:
    py.test --cov flotilla/compute/splicing.py --cov-report term-missing flotilla/test/compute/test_splicing.py
    which will show you which lines aren't covered by the tests.
  • Do the new functions have descriptive
    numpydoc
    style docstrings?
  • If it adds a new feature, is it documented as an IPython Notebook in
    examples/, and is that notebook added to doc/tutorial.rst?
  • If it adds a new plot, is it documented in the gallery, as a .py file
    in examples/?
  • Is it well formatted? Look at the output of make lint.
  • Is it documented in the doc/releases/?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@olgabot
Copy link
Collaborator Author

olgabot commented May 23, 2015

Wrote the relase notes in the wrong branch.. here they are as a clipboard:

Miscellaneous
  • Rasterize lavalamp plot for visualizing many splicing events at once,
    otherwise the image is too big

olgabot added a commit that referenced this pull request May 28, 2015
By default, rasterize the lavalamp plot
@olgabot olgabot merged commit b19728e into master May 28, 2015
@olgabot olgabot deleted the raster_lavalamp branch May 28, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant