Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed capitalization in s:InitDict() #4

Closed
wants to merge 1 commit into from
Closed

Fixed capitalization in s:InitDict() #4

wants to merge 1 commit into from

Conversation

sgur
Copy link

@sgur sgur commented Apr 1, 2014

I fixed s:InitDict() behaviour.

Expected behavior:
s:InitDict() capitalize the key code string

Current behavior:
s:InitDict() uppercase whole key code string

For example:
before call <SID>InitDict('g:Lf_CommandMap', s:Lf_CommandMap) (plugin/leaderf.vim#L145)

let g:Lf_CommandMap = {
      \   '<down>': ['<Down>', '<C-J>', '<C-N>']
      \ , '<up>': ['<Up>', '<C-K>', '<C-P>']
      \ }

after call <SID>InitDict('g:Lf_CommandMap', s:Lf_CommandMap)

let g:Lf_CommandMap = {
      \ ... <snip>,
      \ '<DOWN>': ['<DOWN>', '<C-J>', '<C-N>'],
      \ '<UP>': ['<UP>', '<C-K>', '<C-P>'],
      \ ... <snip>
      \ }

this uppercased string cannot be accepted by startExplAction() in manager.py

@Yggdroot
Copy link
Owner

thanks for your patch, but I don't think this patch is seamless. e.g. <BS>, <LeftMouse>

@sgur
Copy link
Author

sgur commented Apr 14, 2014

Oh, I haven't cared about that pattern. My patch above isn't perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants