Claire updates v1 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test to flag when METADATAID is NULL. Lots of formatting changes automatically occured when opened in Atom (removal of extra spaces)
'Inscribed' can only be the status for sites where DESIG_ENG = 'World Heritage Site (natural or mixed)' 'Adopted' can only be the status for sites where DESIG_ENG = 'Specially Protected Areas of Mediterranean Importance (Barcelona Convention)' Updated check 4.15, and added checks 4.15.a & 4.15.b to address this issue. Added two new functions (invalid_status_Barca & invalid_status_WH) to core_checks.
Added test 2.8.a to flag when REP_AREA is larger than 500,000km2
Make the output file name include a copy of the layer name. Also added a few changes that I missed in the other commits
Add test to ensure non-gov sites have not been removed. to integrity tool.
My previous update wasn't working to check for inv_status. This is now fixed.
I have added extra NaN checks. These are tests 7.9-7.15
Corrected file path to WDPAIDs not to delete, and fixed test. Changed duplicate WDPA_PID to a fail instead of check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last few fixes. Everything works now, ready to create new toolbox.