Added FormatParsha function - fix Lag Be'omer formatting #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s used for other days.
Added FormatParsha function
shmulyeng
changed the title
|
Any chance of getting this merged? |
|
It looks like you also have a parsha change can you explain what the change does? |
I added a blank string to the beginning of the array to align the parsha enum with the Hebrew Parsha array. The enum has a "None" value as the first value. I also added a method to format the Parsha in Hebrew based on date or Parsha. |
|
Can this get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hebrew version of Lag Be'omer uses the Beis prefix regardless of what's used for other days.