Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Use Markdown to render rich text formatting in node notes. #4091

Closed
b8two opened this issue Jun 8, 2022 · 14 comments · Fixed by #5543
Closed

Feature Request: Use Markdown to render rich text formatting in node notes. #4091

b8two opened this issue Jun 8, 2022 · 14 comments · Fixed by #5543
Assignees

Comments

@b8two
Copy link

b8two commented Jun 8, 2022

Hi Ylianst,

When on the General Tab on my FHD Screen, there is a big empty space between the " Group / OS Name" table on the left and the icon on the right. I thought it would be nice to have the "Notes" displayed there scrollable and read only. Keep the "Notes" button to edit the contents.

Additionally it would be nice to use Markdown (or similar) to render rich text formatting in node notes.

If possible, it would be nice to be able to add in some Mesh Central specific syntax to create custom MeshCentral Router links similar to the RDP, HTTP, HTTPS links but can be custom. Something like {Protocol}://{meshID}:{port}/ e.g. the standard HTTP link equivilent http://{meshID}:80/

I think this would help for those people that have some devices with custom port apps that don't apply to all machines in mesh central.

@b8two b8two changed the title Use Markdown to render rich text formatting in node notes. Feature Request: Use Markdown to render rich text formatting in node notes. Jun 8, 2022
@silversword411
Copy link
Contributor

If possible, it would be nice to be able to add in some Mesh Central specific syntax to create custom MeshCentral Router links similar to the RDP, HTTP, HTTPS links but can be custom. Something like {Protocol}://{meshID}:{port}/ e.g. the standard HTTP link equivilent http://{meshID}:80/

Isn't that what meshCmd is all about?
https://ylianst.github.io/MeshCentral/meshcmd/#meshcentral-tcp-port-mapping

@b8two
Copy link
Author

b8two commented Jun 9, 2022

@silversword411
In a way, I was refering more to how deviceMeshRouterLinks feature that applies system wide;
#3911
to have more of a single device customization.

meshCmd is a console app that creates port maps.
MeshRouter is a nice GUI app that also creates port maps and has linked calls with Mesh Central web GUI

deviceMeshRouterLinks feature allows additional Web GUI links to be shown on the Mesh central web to configure MeshRouter.

Above was a suggestion of extending this.

@si458
Copy link
Collaborator

si458 commented Jan 4, 2024

this was added recently in a PR, should already be available in latest release, if not next release,
you can enable it using showNotesPanel: true listed under your domain,
sorry its not markdown language, but text notes is good!

@si458 si458 closed this as completed Jan 4, 2024
@si458 si458 reopened this Aug 25, 2024
@si458
Copy link
Collaborator

si458 commented Aug 25, 2024

i am just reopening this as i was looking into the markdown feature
is this still required, as ive experimented with markedjs and achieved this!
image
image

@si458 si458 mentioned this issue Aug 25, 2024
@si458 si458 self-assigned this Aug 26, 2024
@b8two
Copy link
Author

b8two commented Aug 27, 2024

I've just enabled showNotesPanel: true in my config and it works as expected.

I would like the mark up as some devices I look after have URLs to access, this will allow them to be listed and linked.

@si458
Copy link
Collaborator

si458 commented Aug 27, 2024

@b8two thats ok im looking into it now as this is exactally what #6332 wanted!

@si458
Copy link
Collaborator

si458 commented Aug 27, 2024

@b8two @fordcrews this ok? the textbox is scrollable!
image

si458 added a commit that referenced this issue Aug 27, 2024
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Aug 27, 2024

added for you!
will be in latest docker developer build or github builds for testing
ghcr.io/ylianst/meshcentral:master or npm install Ylianst/MeshCentral (remember no translations in npm build)
or wait until next release

@si458 si458 closed this as completed Aug 27, 2024
@b8two
Copy link
Author

b8two commented Aug 28, 2024

Excellent, My deployment is in Docker, so I'll try to update with the next release that is tied in with image: Typhonragewind/meshcentral-docker

@si458
Copy link
Collaborator

si458 commented Aug 28, 2024

you really should be using the offical docker image as its practially identical ghcr.io/ylianst/meshcentral
and you can even test the development builds with master tag

@b8two
Copy link
Author

b8two commented Sep 11, 2024

@si458 I've updated my docker to the official image. I don't think I found the image back in April when I was converting across from a native install to docker.

Also, one minor update to this mark up, can the links open to a new tab / window?

@si458
Copy link
Collaborator

si458 commented Sep 12, 2024

Sorry for the delay, erm. I'm not sure I'll have to check this?

@si458
Copy link
Collaborator

si458 commented Sep 12, 2024

@b8two ok so the standard markdown url links DONT use _blank to open links in a new page
if you wanted this feature, we would have to integrate a render to open links in a new page
im also not sure if this should be standard or not?

si458 added a commit that referenced this issue Nov 5, 2024
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Nov 5, 2024

@b8two better late than never! fc83211
the notes links will now open in a new tab instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants