Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Login button is not enabled when the account is filled by the browser #6428

Closed
trmdi opened this issue Oct 4, 2024 · 7 comments · Fixed by #6434
Closed

The Login button is not enabled when the account is filled by the browser #6428

trmdi opened this issue Oct 4, 2024 · 7 comments · Fixed by #6434
Assignees
Labels

Comments

@trmdi
Copy link
Contributor

trmdi commented Oct 4, 2024

If you save the login info in the browser, the next time you login it will be auto filled but the login button is still disabled.
image

@trmdi trmdi added the bug label Oct 4, 2024
@si458
Copy link
Collaborator

si458 commented Oct 4, 2024

I noticed this when I use my bitwarden
but don't no why it does it?

If u press enter the button that gets enabled

So I'm guessing it's the prefill isn't registering correctly

@trmdi
Copy link
Contributor Author

trmdi commented Oct 4, 2024

Maybe the Login button needn't be disabled?

@si458
Copy link
Collaborator

si458 commented Oct 5, 2024

i think ive fixed it but i meant to check what browser/OS you was using as you didnt say!

@si458 si458 self-assigned this Oct 5, 2024
si458 added a commit that referenced this issue Oct 5, 2024
Signed-off-by: si458 <simonsmith5521@gmail.com>
@si458
Copy link
Collaborator

si458 commented Oct 5, 2024

fix is here if you wanna patch n try yourself ec75059
basically the button is disabled for security and prevent login bots,
so you need to enter a user and password before its enabled
BUT it seems the onchange commands for the password field are too quick,
and when it checks if the is a value in there, the value is blank as the password manager couldnt type it in quick enough
so just putting a 100ms delay in fixes the issue

@trmdi
Copy link
Contributor Author

trmdi commented Oct 6, 2024

This setTimeout approach does not work for me even with a 3000ms delay.
I'm on the latest Edge/Windows 11.
image

@si458
Copy link
Collaborator

si458 commented Oct 6, 2024

Ok thanks I will test with edge,
As i was testing with firefox which fixed the issue on my mac and android device
It's possible that edge is prefilling the boxes but not the value option!
So might need to identify what it's actually doing

@trmdi
Copy link
Contributor Author

trmdi commented Oct 6, 2024

There is a WON'T FIX issue [1] in Chromium. Maybe we should stop disabling the Submit button and use "required" on the Input fields [2] instead?

Ref:

  1. https://issues.chromium.org/issues/41269130
  2. https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#using_built-in_form_validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants