Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code redundancy #5140

Merged
merged 2 commits into from
May 25, 2023
Merged

Remove code redundancy #5140

merged 2 commits into from
May 25, 2023

Conversation

aymenBox
Copy link
Contributor

@aymenBox aymenBox commented May 18, 2023

Reference Issues/PRs

None

what does this implement fix? Explain your changes.

Group together some CSS code into one class to reduce code redundancy

any other comments.
I'm working on a new UI for my own instance of MeshCentral and I noticed some changes that could be made.

aymenBox added 2 commits May 18, 2023 15:48
removing code redundancy
Followed by some changes in Style.css the same must be done to this file to reduce code redundancy
@aymenBox aymenBox changed the title Patch 1 Remove code redundancy May 18, 2023
@si458
Copy link
Collaborator

si458 commented May 18, 2023

This PR looks too bit of a change?
Did u use github to edit? The seems to be an issue at the moment with this happening

@aymenBox
Copy link
Contributor Author

@si458 I will continue to do more push into this branch if it looks too bit of a change because I noticed a lot's of repeated and unused code , however I do my development on my remote server directly so too many changes to make a fork that's way I edit on Github the things I noticed.

@Ylianst Ylianst merged commit dc6c815 into Ylianst:master May 25, 2023
@Ylianst
Copy link
Owner

Ylianst commented May 25, 2023

This is a good PR, but I think all of the carriage returns where changed in the default.handlebar causing all lines of that file to be shown as changed. I see where you are going with this one and it's a good change. If I get a chance, I will add it in.

@Ylianst
Copy link
Owner

Ylianst commented May 25, 2023

Ok, just added a commit to do that same: e4d8c04

@aymenBox
Copy link
Contributor Author

Hello @Ylianst, thank you for merging this changes and happy to be helpful, however if you can give me some advices on where to start to make a full rewrite and optimization for the front end of meshcentral (as a contribution) , i know this task is not easy and very long and i still working on my own server and i managed to change a lot in the front end which is a lots of modification in the default.handlebar and styles.css file, do you think is it better to continue on this path and slowly keeps modifying the front-end this way or to do a full rewrite of the front-end part one more thing is the translation and deferent file that have to be recreated with deferent languages is there's a better approach also the deferent files for mobiles, any resources will be helpful i have read the published pdf file from the official website i found no clue about the meshcentral-web folder the only clue i found was a comment by you on Github , and lastly thank you 🙏 for this great software can't Wait to learn more and contribute more.

@aymenBox aymenBox deleted the patch-1 branch May 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants