Add .mypy.ini, pylintrc and satisfy pylint, mypy checks
#11
Conversation
| from __future__ import annotations | ||
| from typing import TypeVar, Type | ||
|
|
||
| T = TypeVar("T") # pylint: disable=C0103 |
There was a problem hiding this comment.
Pylint 2.12 (or earlier versions) does not work properly with TypeVar in the (it is fixed in the 2.13).
There was a problem hiding this comment.
Could you please create a GitHub issue to update to Pylint 2.13 when it comes out, and to remove the suppression here?
| return isinstance(other, self.__class__) and self.__dict__ == other.__dict__ | ||
| cls.__eq__ = __eq__ | ||
| cls.__eq__ = __eq__ # type: ignore |
There was a problem hiding this comment.
Mypy do not allow assigning a function to a method (see here).
| @@ -112,10 +112,10 @@ def test_win_condition(self): | |||
| Cell(0, 2), False)] | |||
| for cells, cell, expect in args_and_expect_list: | |||
There was a problem hiding this comment.
Mypy does not inference the right type for cells and the syntax does not allow one to annotate the types of variables when tuple unpacking is used.
| from __future__ import annotations | ||
| from typing import TypeVar, Type | ||
|
|
||
| T = TypeVar("T") # pylint: disable=C0103 |
There was a problem hiding this comment.
Could you please create a GitHub issue to update to Pylint 2.13 when it comes out, and to remove the suppression here?
| @@ -256,23 +259,23 @@ def __last_step(step: int) -> bool: | |||
| return step == Board.size() ** 2 - 1 | |||
|
|
|||
| @staticmethod | |||
| def __surrender(state: State): | |||
| def __surrender(state: State) -> None: | |||
| assert state.phase is Phase.INROUND | |||
There was a problem hiding this comment.
Add another assertion:
# for more players this method would have been implemented quite differently
assert State.player_count() is 2There was a problem hiding this comment.
I left a comment in the example for a reason: I think we need to clarify this new assertion.
| @@ -256,23 +259,23 @@ def __last_step(step: int) -> bool: | |||
| return step == Board.size() ** 2 - 1 | |||
|
|
|||
| @staticmethod | |||
| def __surrender(state: State): | |||
| def __surrender(state: State) -> None: | |||
| assert state.phase is Phase.INROUND | |||
There was a problem hiding this comment.
I left a comment in the example for a reason: I think we need to clarify this new assertion.
No description provided.