CS: function naming consistency #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, this library uses `camelCaps` for function names instead of the WP convention of using `snake_case`. There is no need to change this, we just need to allow for it and fix up the few exceptions to the rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, this library uses
camelCapsfor function names instead of the WP convention of usingsnake_case.There is no need to change this, we just need to allow for it and fix up the one exception to the rules (and allow for one more, but that will be handled via the PHPCS ruleset).
As this involves a
publicmethod, this can be considered a BC-break. However, the reason for the method to bepublicis that it is hooked in viaadd_action(), not because it is a method which external parties are expected to call on, so I expect the BC-break to be theoretical and not to have any impact in practical terms.