InvalidOperatorType Exception: improve documentation, duplicate code and unit test #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and unit test The `$validOperators` were defined in two places, making the chance of these two arrays getting out of sync large and lowering maintainability. I've now: * Removed the `$validOperators` property in the `Whip_InvalidOperatorType` class in favour of adding a new parameter to the constructor. * The one call to the Exception will now pass the operators against which it validates. * The message text of the Exception is now unit tested.
|
Acceptance done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$validOperatorswere defined in two places, making the chance of these two arrays getting out of sync large and lowering maintainability.I've now:
$validOperatorsproperty in theWhip_InvalidOperatorTypeclass in favour of adding a new parameter to the constructor.