Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

275 preprare backend to hook problems and notifications into alert center front end #21647

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Sep 19, 2024

Context

  • We want to add the data we need for the notification ui to the script data.

Summary

This PR can be summarized in the following changelog entry:

  • Adds notification and problem information to the script data.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure you see a notification in the old dashboard. You can make this happen by resetting your indexables.
  • Add the following code to you project: define( 'YOAST_SEO_NEW_DASHBOARD_UI', true );
  • Open the console on the new general page and type window.wpseoScriptData.notifications.active And make sure you see a notification in the console only.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 19, 2024
@vraja-pro
Copy link
Contributor

CR & AC ✅

@vraja-pro vraja-pro added this to the 23.6 milestone Sep 20, 2024
@vraja-pro vraja-pro merged commit 59c08c8 into trunk Sep 20, 2024
20 of 22 checks passed
@vraja-pro vraja-pro deleted the 275-preprare-backend-to-hook-problems-and-notifications-into-alert-center-front-end branch September 20, 2024 08:35
@vraja-pro
Copy link
Contributor

vraja-pro commented Sep 26, 2024

  • Open the console on the new general page and type window.wpseoScriptData.notifications.active And make sure you see a notification.

This was changed in a later PR. The check should be window.wpseoScriptData.alerts to get all the alerts, problems and notifications, active and dismissed. @hardikgohil7988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants