Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change search volume format #21805

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Nov 7, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/related-keyphrase-suggestions 0.1.0] Changes the format of the search volume in the related key phrase suggestions table.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post with. focus key phrase.
  • Click on Get related keyphrases
  • Login to semrush and check you get the table.
  • Check the volume has the short format:
    Screenshot 2024-11-07 at 15 02 04
  • Go to user profile and change the language to Arabic or Hindi and check the Search volume in the table has short format for the specific language.
    Screenshot 2024-11-07 at 15 50 48

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Change the search volume to short format based on locale

fix locale format outside the component
@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 699c97eb7ade900045744720ad8afc20e752be4b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 54.704%

Files with Coverage Reduction New Missed Lines %
packages/js/src/components/SEMrushRelatedKeyphrasesModalContent.js 1 65.91%
Totals Coverage Status
Change from base Build 938cc506d4c8ae494a3948af3c02581086ca0b29: 0.0%
Covered Lines: 29751
Relevant Lines: 54680

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants