Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yoastseo dependencies #21813

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Update yoastseo dependencies #21813

merged 1 commit into from
Nov 11, 2024

Conversation

FAMarfuaty
Copy link
Contributor

@FAMarfuaty FAMarfuaty commented Nov 8, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • [yoastseo] Updates the package dependencies.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • The scripts inside yoastseo should all pass without error, see packages/yoastseo/package.json
  • In the root, run the commands to build the plugin composer install && yarn && grunt build and confirm that the plugin is sill build the same and without an error

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • No further impact

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@FAMarfuaty FAMarfuaty added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 829f76e80ec639bae65e259a87c56868c05ff623

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 51.397%

Totals Coverage Status
Change from base Build 938cc506d4c8ae494a3948af3c02581086ca0b29: -3.3%
Covered Lines: 18588
Relevant Lines: 37353

💛 - Coveralls

@FAMarfuaty FAMarfuaty marked this pull request as ready for review November 11, 2024 08:47
@mykola mykola merged commit 9d1cb6a into trunk Nov 11, 2024
15 of 16 checks passed
@mykola mykola deleted the update-yoastseo-dependencies branch November 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants