Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add premium upsell component #21817

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/related-keyphrase-suggestions 0.1.0] Adds the premium upsell ad with new design for the related keyphrase suggestions modal.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post with focus keyphrase.
  • Make sure Yoast premium in disabled or uninstalled.
  • Click on "Get related keyphrases".
  • Log in to semrush and return to the post to see you are getting the modal with related keyphrase suggestions.
  • Check that you see the upsell ad on the top of the modal:
    Screenshot 2024-11-12 at 17 28 27
  • Enable screen reader and focus on the button, check it says "Opens in a new browser tab"
  • Click on the button and check the link opens in a new tab.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Tailwindify the upsell in the related keyphrase suggestions modal

@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 1e6bc1e4540bc564ae74cdd80f96af35ebc9aa31

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 54.701%

Files with Coverage Reduction New Missed Lines %
packages/js/src/components/modals/SEMrushUpsellAlert.js 2 0.0%
Totals Coverage Status
Change from base Build 9d1cb6a14c317cc44e1470990e1289fdaaf594fe: -0.003%
Covered Lines: 29749
Relevant Lines: 54680

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants