Merge pull request #62 from Yoast/JRF/tests-class-should-be-final

CS/QA: all test classes should be either abstract or final
Yoast · Sep 23, 2023 · 55643b9 · 55643b9
2 parents 88ec1b8 + 1aaf094
commit 55643b9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/tests/BrainMonkey/TestCaseTest.php b/tests/BrainMonkey/TestCaseTest.php
@@ -19,7 +19,7 @@
  *
  * @covers \Yoast\WPTestUtils\BrainMonkey\TestCase
  */
-class TestCaseTest extends TestCase {
+final class TestCaseTest extends TestCase {
 
 	/**
 	 * Verify that the basic BrainMonkey functionality has been made available.
@@ -273,7 +273,7 @@ public function testDoubleForUnavailableClassAllowsSettingProperties() {
 			'Class UnavailableClassB appears to already exist'
 		);
 
-		static::makeDoubleForUnavailableClass( UnavailableClassB::class );
+		self::makeDoubleForUnavailableClass( UnavailableClassB::class );
 
 		$unavailable_class           = new UnavailableClassB();
 		$unavailable_class->property = 10;

diff --git a/tests/BrainMonkey/YoastTestCaseTest.php b/tests/BrainMonkey/YoastTestCaseTest.php
@@ -9,7 +9,7 @@
  *
  * @covers \Yoast\WPTestUtils\BrainMonkey\YoastTestCase
  */
-class YoastTestCaseTest extends YoastTestCase {
+final class YoastTestCaseTest extends YoastTestCase {
 
 	/**
 	 * Verify the behaviour of the `get_bloginfo()` stub.

diff --git a/tests/Helpers/ExpectOutputHelperTest.php b/tests/Helpers/ExpectOutputHelperTest.php
@@ -16,7 +16,7 @@
  *
  * @covers \Yoast\WPTestUtils\Helpers\ExpectOutputHelper
  */
-class ExpectOutputHelperTest extends TestCase {
+final class ExpectOutputHelperTest extends TestCase {
 
 	use AssertionRenames;
 	use AssertStringContains;