Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default classname #358

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Set default classname #358

merged 1 commit into from
Oct 25, 2017

Conversation

IreneStr
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • Add default classname yoast-video-tutorial to the VideoDescriptionItem.

Relevant technical choices:

  • Set the same default classname as in the video tutorial component.

Test instructions

This PR can be tested by following these steps:

  • Run yarn test and check whether the warning is gone.

Fixes #357

@abotteram
Copy link
Contributor

abotteram commented Oct 25, 2017 •
edited
Loading

CR 👍
Acceptance 👍

@abotteram abotteram merged commit a388f12 into develop Oct 25, 2017
@abotteram abotteram added this to the 2.11 milestone Oct 25, 2017
@IreneStr IreneStr mentioned this pull request Oct 27, 2017
Closed
IreneStr added a commit that referenced this pull request Oct 27, 2017
@IreneStr
Merge branch 'release/2.11'
e80825f 
Added

Components

Notification component. #348
AnalysisResult component. #352
ContentAnalysis component. #359

Other additions

Added callbacks to notify tab switch in YoastTabs. #346
setSeoResultsForKeyword action and reducer implementation. #355
Added default className to VideoDescriptionItem component. #358
@IreneStr IreneStr deleted the stories/fix-video-tutorial-test-warning branch November 7, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@IreneStr @abotteram