Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Wizard previous and next buttons focusable again #369

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Nov 6, 2017

Summary

This PR can be summarized in the following changelog entry:

  • Made the Onboarding Wizard previous and next buttons focusable again

Relevant technical choices:

  • Removes the disableKeyboardFocus from the buttons. Seems this prop was initially used in material-ui just for styling purposes, instead now it's also responsible for setting the tabindex attribute.

Test instructions

  • on the develop branch, use the keyboard to Tab to the buttons and see they're not focusable
  • see they have a tabindex="-1" attribute
  • switch to this branch
  • check the buttons are now focusable
  • check they have a tabindex="0" attribute

Aside note: as mentioned in the issue, material-ui does lots of things to control elements focusability programmatically. Not sure I really like this approach. Keeping controls behaviors as native as possible is always a better choice.

Fixes #368

@abotteram
Copy link
Contributor

CR 👍

@abotteram
Copy link
Contributor

Acceptance 👍

@abotteram abotteram merged commit f64c4d2 into develop Nov 20, 2017
@abotteram abotteram deleted the stories/368-wizard-previous-next-buttons-focus branch November 20, 2017 09:17
@abotteram abotteram added this to the 2.11.3 milestone Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants