Make the Wizard previous and next buttons focusable again #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
disableKeyboardFocus
from the buttons. Seems this prop was initially used in material-ui just for styling purposes, instead now it's also responsible for setting the tabindex attribute.Test instructions
tabindex="-1"
attributetabindex="0"
attributeAside note: as mentioned in the issue,
material-ui
does lots of things to control elements focusability programmatically. Not sure I really like this approach. Keeping controls behaviors as native as possible is always a better choice.Fixes #368