Stories/af/9601 replacement variables suggestions speak #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
%
to search for a replacement variable, bothonSearchChange
andonChange
run the latter callsserializeContent
which I guess fully re-renders the component because at that point the number of replacementVariables in the state is the initial ones from the props /Cc @atimmercomponentDidUpdate()
Test instructions
yarn start
then go to http://localhost:3333/)%
etc.#a11y-speak-assertive
gets a message with the correct number of search resultsFixes Yoast/wordpress-seo#9601