Update DraftJS Mention Plugin. #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CR 👍 |
abotteram
reviewed
May 15, 2018
| import sortedIndexBy from "lodash/sortedIndexBy"; | ||
| import trim from "lodash/trim"; | ||
|
|
||
| const AFFIX = "%%"; |
There was a problem hiding this comment.
Could be renamed to CIRCUMFIX.
boblinthorst
approved these changes
May 16, 2018
| * | ||
| * @returns {Array} Array of found indices. | ||
| */ | ||
| const getIndicesOf = ( searchTerm, text ) => { |
There was a problem hiding this comment.
We probably want to unit test this function in the future.
| * @returns {Object} The raw data ready for convertFromRaw. | ||
| */ | ||
| export function unserializeEditor( content ) { | ||
| export function unserializeEditor( content, tags ) { |
There was a problem hiding this comment.
As discussed in person. In the future, we're gonna want to extract some parts of this function to make ik more comprehensive.
|
Acceptance: ok 👍 |
boblinthorst
deleted the
stories/fix-console-warning-when-opening-replace-var-suggestions-in-react-snippet-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
draft-js-mention-pluginto get rid of the console warning.serializeandunserialize. Partly for the major version upgrade. And partly for the marking issue.Test instructions
This PR can be tested by following these steps:
Fixes Yoast/wordpress-seo#9684 and Yoast/wordpress-seo#9653